Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation

[Lukasz Majewski <lukma at denx dot de>]

Hi Andreas,

> On Feb 11 2020, Lukasz Majewski wrote:
> 
> > diff --git a/include/mqueue.h b/include/mqueue.h
> > index 3c66f1711e..3de890905c 100644
> > --- a/include/mqueue.h
> > +++ b/include/mqueue.h
> > @@ -10,4 +10,13 @@ extern __typeof (mq_timedreceive)
> > __mq_timedreceive __nonnull ((2, 5)); hidden_proto
> > (__mq_timedreceive) hidden_proto (mq_setattr)
> >  # endif
> > +#if __TIMESIZE == 64
> > +# define __mq_timedsend_time64 __mq_timedsend
> > +#else
> > +#include <include/time.h>  
> 
> I think struct __timespec64 should be moved to a separate file, so
> that we do not need to pull in the whole <time.h> namespace here.
> 

Just to clarify - the time.h here is from ./include glibc sources
directory, so it is "internal" for glibc.

In other words - I would like to know if your comment was regarding
polluting the glibc internal namespace?

> Andreas.
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgp0j4PyBZTe8.pgp
Description: OpenPGP digital signature