This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/15] powerpc: Consolidate Linux syscall definition
On 11/02/2020 16:43, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> +/* Define __set_errno() for INLINE_SYSCALL macro below. */
>> +#ifndef __ASSEMBLER__
>> +#include <errno.h>
>> +#endif
>
> Missing indentation (but the existing files are not consistent about
> that).
>
>> +/* Pointer mangling support. */
>> +#if defined(__PPC64__) || defined(__powerpc64__)
>> +# define LOAD ld
>> +# define TPREG r13
>> +#else
>> +# define LOAD lwz
>> +# define TPREG r2
>> +#endif
>
> Can you restrict those to #ifdef __ASSEMBLER__? <sysdep.h> is a
> fairly widely included header, and this has the potential of breaking
> future changes that compile on other architectures.
Ack.
>
> Rest looks okay to me, but maybe a POWER maintainer wants to have a
> look as well.
>