Re: [PATCH v2] sunrpc: Properly clean up if tst-udp-timeout fails

[Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>]

Andreas Schwab <schwab@suse.de> writes:

> On Feb 12 2020, Matheus Castanho wrote:
>
>> @@ -177,6 +180,14 @@ server_dispatch (struct svc_req *request, SVCXPRT *transport)
>>      }
>>  }
>>  
>> +/* Function to be called before exit to make sure the
>> +   server process is properly killed.  */
>> +static void
>> +kill_server (void)
>> +{
>> +  kill(server_pid, SIGTERM);
>
> Style: space before paren.

Fixed.

>> @@ -381,16 +392,17 @@ do_test (void)
>>    TEST_VERIFY_EXIT (transport != NULL);
>>    TEST_VERIFY (svc_register (transport, PROGNUM, VERSNUM, server_dispatch, 0));
>>  
>> -  pid_t pid = xfork ();
>> -  if (pid == 0)
>> +  server_pid = xfork ();
>> +  if (server_pid == 0)
>>      {
>>        svc_run ();
>>        FAIL_EXIT1 ("supposed to be unreachable");
>>      }
>> +  atexit(kill_server);
>
> Likewise.

Fixed.

Pushed as f34c4d0f10ed09500d5f0ebd473c3f37ce4989d7.

Thanks!

-- 
Tulio Magno