This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/7] nss_files: Use NSS_DECLARE_MODULE_FUNCTIONS
- From: Florian Weimer <fweimer at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 13 Feb 2020 09:12:11 +0100
- Subject: Re: [PATCH 6/7] nss_files: Use NSS_DECLARE_MODULE_FUNCTIONS
- References: <xnh7zvcm5w.fsf@greed.delorie.com>
* DJ Delorie:
> Florian Weimer <fweimer@redhat.com> writes:
>> nss/nss_files/files-alias.c | 2 ++
>> nss/nss_files/files-ethers.c | 3 +++
>> nss/nss_files/files-grp.c | 3 +++
>> nss/nss_files/files-hosts.c | 2 ++
>> nss/nss_files/files-init.c | 3 +++
>> nss/nss_files/files-initgroups.c | 3 +++
>> nss/nss_files/files-key.c | 2 ++
>> nss/nss_files/files-netgrp.c | 2 ++
>> nss/nss_files/files-network.c | 3 +++
>> nss/nss_files/files-proto.c | 2 ++
>> nss/nss_files/files-pwd.c | 3 +++
>> nss/nss_files/files-rpc.c | 2 ++
>> nss/nss_files/files-service.c | 2 ++
>> nss/nss_files/files-sgrp.c | 3 +++
>> nss/nss_files/files-spwd.c | 3 +++
>> 15 files changed, 38 insertions(+)
>
> LGTM. Seems to be some inconsistency about whether to use <nss.h> or
> "nsswitch.h" - I wonder if always using "nsswitch.h" *just* for
> consistency would be worth the cost?
>
> Reviewed-by: DJ Delorie <dj@redhat.com>
Maybe we should add nss_files.h if there any common declarations?
Thanks,
Florian