This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Use gcc -finput-charset=ascii for check-installed-headers.
- From: Stefan Liebler <stli at linux dot ibm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: Zack Weinberg <zackw at panix dot com>
- Date: Thu, 13 Feb 2020 10:40:55 +0100
- Subject: Re: [PATCH v2] Use gcc -finput-charset=ascii for check-installed-headers.
- References: <20200213093438.52242-1-stli@linux.ibm.com>
On 2/13/20 10:34 AM, Stefan Liebler wrote:
A non-ascii character in the installed headers leads now to:
error: failure to convert ascii to UTF-8
Such a finding in s390 specific fenv.h leads to fails in GCC testsuite.
See glibc commit 08aea89ef67c5780ae734073494df0a451bce20f.
Adding this gcc option also to our tests was proposed by Florian Weimer.
This change also found a hit in resource.h where now "microseconds" is used.
I've adjusted all the resource.h files.
I've used the following command to check for further hits in headers.
LC_ALL=C find -name "*.h" -exec grep -PHn "[\x80-\xFF]" {} \;
Tested on s390x and x86_64.
---
Compared to v1, this patch just uses "microseconds" instead of "us" as
suggested by Zack Weinberg
(https://www.sourceware.org/ml/libc-alpha/2020-02/msg00510.html).
Zack, can you please have a final look before I commit the patch.
Bye,
Stefan