This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v3 0/8] Always use 32-bit time_t for certain syscalls
- From: Alistair Francis <alistair dot francis at wdc dot com>
- To: libc-alpha at sourceware dot org
- Cc: alistair23 at gmail dot com, Alistair Francis <alistair dot francis at wdc dot com>
- Date: Fri, 14 Feb 2020 08:31:26 -0800
- Subject: [PATCH v3 0/8] Always use 32-bit time_t for certain syscalls
- Ironport-sdr: Z/hK/2hELRWr4wDk5fWQrHfs9MBNGq8H34Al7Cwyr3faATaGeB9GUGnh5whQ2s470ZP+Q9mGo9 7REp6Ujp6hlxgoLzCTQlOZ014f/7SvaVix/As316z9ME6xjVnFr5yZ8oAxOlWJ2Fb4h2RA3/TY HvKu7wPRKsZpjSCPcyf+ZvJBkbTk0EtA0XXYHRSkeTMPPHzyN3dTwx/Qav/3xnn1/712mpV5Xy z0epoB+aSmrTxs72kmqGUn/A8HB6f0wE6rk15wbv4r9Ti5nGUPqAGRjwfVMiFs0QSXES8rg9Tx Tzw=
- Ironport-sdr: E5pQD7AwrSA66nXt8wllHcIRijuPwQMcimHELBTN7zh7n4WLZrSrt9pVtNHz838+x5ElholuN+ 7kdLMhXe1xp9MM5PECQgXRkkLihh4KEspEdEadI4KqvWuf9h9WIFUaXcWv9mJD6c1oZi3n0BSw CCooYGwsaWOTNkiDdkpIDaFPrWp0qLRREWf5SadHBNeIbNhPkOKJW1bwfqBo77zIvKzBS3qfZO vogrhvfXnqfF/e9uMOC+NLGBlTova35VWXZiEk9/NM2E1avTD7JzeJIswX4Ij1jj7U1x9AMB4f scibF6oXWU+/laxQDjCDlM7x
- Ironport-sdr: 6LCImx0xsRA3WndVBDl9HnHGbLHUr0lX5EfUz0BxzyQR9P2/fpuhEM+b6ipaJOdnU3oa+nEJom sOAQsRApn5Z/Gex2mRUPVz1DdL64vD1okdCH5QKsUsv9SNZs0zH+X4uvXgLXyMOaOcJzq0PVot 4SHQI2aHI8X4Xq7+U7THQysQmcCqu/prYjBbpD5afVxAiYtAlD+Y/i1A9sKCnzYSPzTiUkmXl6 4rxxZ5nZaTRrhwpHSz8oZO2Mw5zzg8ESXLpLBnrmP3Bxft+w6HfiWZ/1Z/t71ECz/sy2P97occ heg=
- Wdcironportexception: Internal
On y2038 safe 32-bit systems the Linux kernel expects itimerval
and rusage to use a 32-bit time_t, even though the other time_t's
are 64-bit.
This series converts getitimer, setitimer, getrusage and wait4 to be
both y2038 safe and pass a 32-bit time_t based on the
__KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 macro. On 32-bit systems
we will pass a 32-bit time to the kernel (no matter the time_t size). This is
no change for most 64-bit architectures or 32-bit architectures with a 32-bit time_t.
We can also remove the old Alpha functions as this is now handled genericly.
I don't have a way to test this on Alpha, would someone mind testing it for me?
This follows the standard y2038 conversion so that we don't break
backwards compatibility but we expose a 64-bit version for y2038 safe
architectrures (like RV32).
This series was tested by running:
./scripts/build-many-glibcs.py ... compilers
./scripts/build-many-glibcs.py ... glibcs
on my x86_64 machine.
I also ran make check on RV32 and I only see a total of 10 test failures.
Alistair Francis (8):
sysv/linux: Rename alpha functions to be alpha specific
time: Add a timeval with a 32-bit tv_sec and tv_usec
time: Add a __itimerval64 struct
sysv: Define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
linux: Use long time_t __getitimer/__setitimer
resource: Add a __rusage64 struct
linux: Use long time_t for wait4/getrusage
sysv/alpha: Use generic __timeval32 and helpers
bits/typesizes.h | 6 +
include/sys/resource.h | 120 ++++++++++++++++++
include/time.h | 71 +++++++++++
.../unix/sysv/linux/alpha/bits/typesizes.h | 3 +
sysdeps/unix/sysv/linux/alpha/osf_adjtime.c | 7 +-
sysdeps/unix/sysv/linux/alpha/osf_getitimer.c | 3 +-
sysdeps/unix/sysv/linux/alpha/osf_getrusage.c | 8 +-
.../unix/sysv/linux/alpha/osf_gettimeofday.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_setitimer.c | 5 +-
.../unix/sysv/linux/alpha/osf_settimeofday.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_utimes.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_wait4.c | 8 +-
.../unix/sysv/linux/generic/bits/typesizes.h | 7 +
sysdeps/unix/sysv/linux/getitimer.c | 61 +++++++++
sysdeps/unix/sysv/linux/getrusage.c | 58 +++++++++
sysdeps/unix/sysv/linux/s390/bits/typesizes.h | 6 +
sysdeps/unix/sysv/linux/setitimer.c | 95 ++++++++++++++
.../unix/sysv/linux/sparc/bits/typesizes.h | 6 +
.../unix/sysv/linux/{alpha => }/tv32-compat.h | 86 +++++--------
sysdeps/unix/sysv/linux/wait4.c | 49 ++++++-
sysdeps/unix/sysv/linux/x86/bits/typesizes.h | 3 +
21 files changed, 541 insertions(+), 73 deletions(-)
create mode 100644 sysdeps/unix/sysv/linux/getitimer.c
create mode 100644 sysdeps/unix/sysv/linux/getrusage.c
create mode 100644 sysdeps/unix/sysv/linux/setitimer.c
rename sysdeps/unix/sysv/linux/{alpha => }/tv32-compat.h (59%)
--
2.25.0