This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Always do locking when accessing streams (bug 15142, bug 14697)
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 16 Feb 2020 14:38:45 +0100
- Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142, bug 14697)
- References: <mvmy2t6a8ok.fsf@suse.de>
* Andreas Schwab:
> Now that abort no longer calls fflush there is no reason to avoid locking
> the stdio streams anywhere. This fixes a conformance issue and potential
> heap corruption during exit. The test nptl/tst-stdio1 is removed as that
> was expecting the problematic behaviour.
I'm not sure if the justification is correct. We don't know if there
are programs which call flockfile on some file and expect exit to
still work (and terminate the program), which is part of what
nptl/tst-stdio1 tests.
If there are such programs, we may need to make the new behavior
conditional on a new symbol version for exit. But I guess we can put
in your patch now and see if testing shows any problems.