This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move implementation of <file_change_detection.h> into a C file


* Stefan Liebler:

> Hi Florian,
>
> I've run some builds on my s390x and x86_64 machines with your applied
> patch. I do not see the -Werror=maybe-uninitialized anymore.
>
> Despite of the whitespace issues, this patch looks good to me.
>
> At least the second line of arguments for __file_is_unchanged needs
> two more spaces (see below).
>
> I've also opened include/file_change_detection.h and
> io/file_change_detection.c in my emacs and it showed more whitespace
> errors: tab vs whitespaces.
> Please have a look at the attached patch to see what I mean. I'm not
> exactly sure if this is really required. If yes, please also check the
> remaining files in the patch.

Thanks.  I believe I fixed up the whitespace issues and pushed the
patch.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]