This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ldbl-128ibm: make ieee754.h work with IEEE 128 long double
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc:
- Date: Tue, 18 Feb 2020 11:05:50 -0300
- Subject: Re: [PATCH] ldbl-128ibm: make ieee754.h work with IEEE 128 long double
- References: <20200211171252.10941-1-murphyp@linux.vnet.ibm.com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> Instead of attempting something more creative, just copy
> the small struct from ldbl-128 and enable it when IEEE
> long double is present, and update the ibm long double
> variant if supported.
>
> Likewise, provide a shadow copy of math_ldbl.h to prevent
> the ibm128 specific long double header from poisoning
> unrelated files due to it's usage in math_private.h.
LGTM with a cosmetic change.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> @@ -121,12 +181,16 @@ union ieee754_double
> -0.0. No other requirements are made; so, for example, 1.0 may be
> represented as (1.0, +0.0) or (1.0, -0.0), and the low part of a
> NaN is don't-care. */
> -
> union ibm_extended_long_double
> {
> - long double ld;
> +#if __LONG_DOUBLE_USES_FLOAT128 == 1 && __GNUC_PREREQ (7, 0)
This is missing an indentation, like the else and endif clauses below.
--
Tulio Magno