This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/6] Prepare redirections for IEEE long double on powerpc64le


And committed. Thank you Gabriel and community for the heavy lifting on this and the many changes leading up to it. (My apologies for the email delay. Some SMTP issues cropped up last night)

On 2/17/20 8:34 AM, Paul E Murphy wrote:
Ping x2.  This has been run through all configs of many-build-glibcs.py without any apparent issues.  Hearing nothing, I will commit this later today.

On 2/10/20 3:32 PM, Paul E Murphy wrote:
Ping? If no objections I would like to commit this next Monday.

I was under the incorrect assumption this patch had been sent out
in December as-is.  This is the continuation of https://sourceware.org/ml/libc-alpha/2019-12/msg00515.html based on my feedback from https://sourceware.org/ml/libc-alpha/2019-12/msg00521.html .

On 2/3/20 3:10 PM, Paul E. Murphy wrote:
From: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>

New since v4.

   - Thanks, Paul, for the suggestion to split it from the last patch.

-- 8< --
All functions that have a format string, which can consume a long double
argument, must have one version for each long double format supported on
a platform.  On powerpc64le, these functions currently have two versions
(i.e.: long double with the same format as double, and long double with
IBM Extended Precision format).  Support for a third long double format
option (i.e. long double with IEEE long double format) is being prepared
and all the aforementioned functions now have a third version (not yet
exported on the master branch, but the code is in).

For these functions to get selected (during build time), references to
them in user programs (or dependent libraries) must get redirected to
the aforementioned new versions of the functions.  This patch installs
the header magic required to perform such redirections.

Notice, however, that since the redirections only happen when
__LONG_DOUBLE_USES_FLOAT128 is set to 1, and no platform (including
powerpc64le) currently does it, no redirections actually happen.
Redirections and the exporting of the new functions will happen at the
same time (when powerpc64le adds ldbl-128ibm-compat to their Implies.
---
  argp/argp.h               |  3 ++-
  libio/bits/stdio-ldbl.h   | 46 ++++++++++++++++++++++++++-------------
  libio/stdio.h             | 16 +++++++++-----
  misc/bits/syslog-ldbl.h   |  4 ++--
  misc/err.h                |  3 ++-
  misc/error.h              |  6 +++--
  misc/sys/cdefs.h          | 38 ++++++++++++++++++++++++++++++--
  misc/sys/syslog.h         |  4 +++-
  stdio-common/printf.h     |  3 ++-
  stdlib/bits/stdlib-ldbl.h | 22 +++++++++++++++++++
  stdlib/monetary.h         |  3 ++-
  stdlib/stdlib.h           |  4 +++-
  wcsmbs/bits/wchar-ldbl.h  | 36 +++++++++++++++++++++++++-----
  wcsmbs/wchar.h            | 14 +++++++-----
  14 files changed, 159 insertions(+), 43 deletions(-)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]