This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Undefine redirections after long double definition on __LDBL_COMPAT [BZ #23294]


My only contribution to this patch is to fix the merge conflict in the Makefile while rebasing.

Note, this does address the feedback from Joseph [1] about adding a test which will fail without this change. I Have verified the test does fail without the change.

If there are no further requests or objections for this patch, I would like to commit it friday. It is necessary to for functional redirection support in ldbl-128ibm-compat.

[1] https://sourceware.org/ml/libc-alpha/2018-06/msg00600.html


Reviewed-by: Paul E. Murphy <murphyp@linux.vnet.ibm.com>

On 2/17/20 9:08 AM, Paul E Murphy wrote:
Ping.

On 2/3/20 3:10 PM, Paul E. Murphy wrote:
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

After defining the long double redirections to double, __MATHDECL_1 has
to be redefined to its previous state in order to avoid redirecting all
subsequent types.
---
  math/complex.h                                | 10 ++-
  math/math.h                                   | 18 ++--
  sysdeps/ieee754/ldbl-opt/Makefile             |  4 +-
  .../ldbl-opt/test-redirection-ldbl-64.c       | 87 +++++++++++++++++++
  4 files changed, 112 insertions(+), 7 deletions(-)
  create mode 100644 sysdeps/ieee754/ldbl-opt/test-redirection-ldbl-64.c


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]