This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/13] nptl: Use .NOTPARALLEL in Makefile only if actually running tests



On 11/02/2020 08:06, Florian Weimer wrote:
> It is safe to build the tests in parallel.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

> ---
>  nptl/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/nptl/Makefile b/nptl/Makefile
> index 6f210d60e3..40f27ea7cd 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -693,7 +693,9 @@ tst-audit-threads-ENV = LD_AUDIT=$(objpfx)tst-audit-threads-mod1.so
>  
>  CFLAGS-tst-unwind-thread.c += -funwind-tables
>  
> -# The tests here better do not run in parallel
> +# The tests here better do not run in parallel.
> +ifeq ($(run-built-tests),yes)
>  ifneq ($(filter %tests,$(MAKECMDGOALS)),)
>  .NOTPARALLEL:
>  endif
> +endif
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]