This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 11/13] Add hidden prototypes for __sched_getparam, __sched_getscheduler



On 11/02/2020 08:06, Florian Weimer wrote:
> This will enable them to be used in libc.so without PLTs.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

> ---
>  include/sched.h    | 2 ++
>  posix/sched_getp.c | 1 +
>  posix/sched_gets.c | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/include/sched.h b/include/sched.h
> index 4abc440176..b0bf971c93 100644
> --- a/include/sched.h
> +++ b/include/sched.h
> @@ -7,10 +7,12 @@ extern int __sched_setparam (__pid_t __pid,
>  			     const struct sched_param *__param);
>  libc_hidden_proto (__sched_setparam)
>  extern int __sched_getparam (__pid_t __pid, struct sched_param *__param);
> +libc_hidden_proto (__sched_getparam)
>  extern int __sched_setscheduler (__pid_t __pid, int __policy,
>  				 const struct sched_param *__param);
>  libc_hidden_proto (__sched_setscheduler)
>  extern int __sched_getscheduler (__pid_t __pid);
> +libc_hidden_proto (__sched_getscheduler)
>  extern int __sched_yield (void);
>  libc_hidden_proto (__sched_yield)
>  extern int __sched_get_priority_max (int __algorithm);

Ok.

> diff --git a/posix/sched_getp.c b/posix/sched_getp.c
> index 32a5087850..014ea0f7ce 100644
> --- a/posix/sched_getp.c
> +++ b/posix/sched_getp.c
> @@ -27,6 +27,7 @@ __sched_getparam (pid_t pid, struct sched_param *param)
>    __set_errno (ENOSYS);
>    return -1;
>  }
> +libc_hidden_def (__sched_getparam)
>  stub_warning (sched_getparam)
>  
>  weak_alias (__sched_getparam, sched_getparam)

Ok.

> diff --git a/posix/sched_gets.c b/posix/sched_gets.c
> index 356e2f22fe..07dd67054f 100644
> --- a/posix/sched_gets.c
> +++ b/posix/sched_gets.c
> @@ -27,6 +27,7 @@ __sched_getscheduler (pid_t pid)
>    __set_errno (ENOSYS);
>    return -1;
>  }
> +libc_hidden_def (__sched_getscheduler)
>  stub_warning (sched_getscheduler)
>  
>  weak_alias (__sched_getscheduler, sched_getscheduler)
> 

OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]