This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] ldconfig: trace origin paths with -v
- From: Joseph Myers <joseph at codesourcery dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Feb 2020 18:09:42 +0000
- Subject: Re: [patch] ldconfig: trace origin paths with -v
- Ironport-sdr: yo+hgjXfGLD1s0BEn3FGq16dvtRkLnO8DkAI2J1maE7+FSUmlB9ymZr+z08kXfQaNpW8L2xhN0 pqS1KTkXUqRK2pbKJFqr9Okm9aEh5Rfe3kZDUbr246mOEC7twKeP62ChQen1ZjV7wkzzt9rsYj zVBOryhJVy0jW8UbJHmYlA6wB2A51Xnk7dn102QRPKglNT1qZRuYgyHAoK+gX03GDGxzs38ckC 4sZR0GmdfCbcF48yTdtKLclkhgOdzscHTBh+ZvJIueLXwhOXckjBtqbPtCYBX+mN6NzNELCDDs RaU=
- Ironport-sdr: +HbJuaCxhagGCChIL8FtnPHyNyVoUyphbE3Qp/TQFCHfYFJp35DTmh04DMcIpEx8ZLivzL5txZ rZTfU0uKLknd+qFLOmIxP8560HgU/ULvu3T0dut+rCATP5Fgprujrj0PtU1ownbtfIaFURwTHP amtf2312yZfFcZF+dQtK3zD4Idsyvha8AINBqJGGiEyW0aFGidPADYFDOTn8QigY0ZTmcsyWrd QLmAByWMqsrxdkF03Szj6ndCuWZAeejf/kApHKgTupBqdQQ8yOkkz+Q1TVlA9cUP+SzVPlYkwZ mgw=
- References: <xnftf6h3fd.fsf@greed.delorie.com>
On Wed, 19 Feb 2020, DJ Delorie wrote:
> @@ -344,7 +346,12 @@ add_single_dir (struct dir_entry *entry, int verbose)
> if (ptr->ino == entry->ino && ptr->dev == entry->dev)
> {
> if (opt_verbose && verbose)
> - error (0, 0, _("Path `%s' given more than once"), entry->path);
> + {
> + error (0, 0, _("Path `%s' given more than once"), entry->path);
> + fprintf (stderr, "(from %s:%d and %s:%d)\n",
> + entry->from_file, entry->from_line,
> + ptr->from_file, ptr->from_line);
This looks like it's a message, for human readers rather than for
automated parsing, giving extra information about the previous message.
That previous message is marked up with _() for translation, and as this
new message includes English words, it should be marked up for translation
as well.
--
Joseph S. Myers
joseph@codesourcery.com