This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "fweimer at redhat dot com" <fweimer at redhat dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "arnd at arndb dot de" <arnd at arndb dot de>, "palmerdabbelt at google dot com" <palmerdabbelt at google dot com>, "zongbox at gmail dot com" <zongbox at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, "adhemerval dot zanella at linaro dot org" <adhemerval dot zanella at linaro dot org>, "macro at wdc dot com" <macro at wdc dot com>, Alistair Francis <alistair23 at gmail dot com>, arcml <linux-snps-arc at lists dot infradead dot org>, "joseph at codesourcery dot com" <joseph at codesourcery dot com>
- Date: Wed, 19 Feb 2020 18:42:18 +0000
- Subject: Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+c27kLE0BVRK1Ub2dMBqDTCi1nw8iw4W8vMjqraNoBo=; b=lNv3y2FEEg1GG2/csKoyhbM+uvUO8Y8pbqAuX/HlIjpU8TQfGfS193Q50UEMRzRMw7oarNsCSr3a5P6IoCfrF0pHcQLdLBqK8sRAYwMTIiPiYxC7cmyp2UjWHMFltfDivkwnZfl14GAsROOLz9BBKWAlin4NbIsF5e1+bPgUEn1kbd/49FVNyKKTsvek3TpWgvgGgouOZw28gItrB/vI7e1xcbekhcaGUPL5sOgd7SYtnGQX+3UQRPVDLmceQFNdB77jKRMqsX1EdMkuBstaqyuiF+KjI9HGhaG8slq0q2MiK3O3HSDNFiIQxn0EWW6smPHX/ZnxH5aOwBvIRIVEdQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WnIyJJ/zsMPiu3Vg77OYIMTWyX7JYhmLSYbbY8DU1gf9Dux7bAA6Fu2OLx4X8+i3b1rScCJueW+OJz75XFovgEZNevUFRvuutIv8y6BjVs/Uz03jcHq7vQGY3XnzW8shxYNjOiB0FlYL7EdJJRo32WuYM55iIITyD8wWUjITdVbTIfLrQ7zif8li8JsDW7ZgXipJXMbg2K2bhu8/uPOIii2Y8m4EWTsk8rH2UwIla1wgk50V60yGzTa4aizE92VszFlTH3hW0Q/ngW1wZnht9W7Jn2YdvDypZe1R0NjfMhJVUk2xLFITT0L4bhNpF8iTynBiThPVOVxONANoK6tTQQ==
- References: <cover.1578824547.git.alistair.francis@wdc.com> <4e95f95966d8d7c6a8339160dc62d81c1f6a1bfb.1578824547.git.alistair.francis@wdc.com> <67f2298c-30ab-1508-4a10-6ee285df7ad1@synopsys.com> <CAKmqyKO6u15cDbQQ644GrABi=6WWQsNLiCVLszrmDCdcWBnCPA@mail.gmail.com> <c9f11e9e-7c33-0000-e32c-346d425d7c69@synopsys.com> <mvmimk3567z.fsf@suse.de>
On 2/19/20 12:30 AM, Andreas Schwab wrote:
> On Feb 19 2020, Vineet Gupta wrote:
>
>> On 2/18/20 5:03 PM, Alistair Francis wrote:
>>>>> +#define STAT_IS_KERNEL_STAT 1
>>>> Isn't this irrelevant: seems to be only used for legacy __NR_stat/__NR_stat64
>>>> syscalls based__xstat()/__xstat64().
>>> Is it? It seems to be used in a few places, including:
>>>
>>> sysdeps/unix/sysv/linux/fxstatat.c
>>> sysdeps/unix/sysv/linux/xstatconv.c
>> AFAIK that is not part of the asm-generic syscall ABI which ARC, RISCV et al use !
>
> The latter is still included by everyone, though.
Correct, although it only builds a "dummy" struct for #ifdef STAT_IS_KERNEL_STAT
i.e. for either values of this define - we might as well move that dummy out and
make the rest of code ifndef.
Rest of code in that function __xstat_conv is not meant for asm-generic syscall
ABI anyways.
Thx,
-Vineet