This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- From: Florian Weimer <fweimer at redhat dot com>
- To: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- Cc: "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, "arnd\@arndb.de" <arnd at arndb dot de>, "linux-snps-arc\@lists.infradead.org" <linux-snps-arc at lists dot infradead dot org>, "alistair23\@gmail.com" <alistair23 at gmail dot com>, "lukma\@denx.de" <lukma at denx dot de>
- Date: Mon, 24 Feb 2020 20:13:01 +0100
- Subject: Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- References: <20200224182305.28027-1-vgupta@synopsys.com> <87wo8bn839.fsf@oldenburg2.str.redhat.com> <d56495ad-c532-9e00-7f67-fa2626f9d901@synopsys.com>
* Vineet Gupta:
> On 2/24/20 10:39 AM, Florian Weimer wrote:
>>> +# undef STAT64_IS_NOT_KERNEL_STAT64
>>
>> Sorry, I think that going forward, we prefer that such macros are always
>> defined, with values 0 or 1 as appropriate.
>
> And that means we also need to additionally define this to 0 in all
> ports which don't end up including the generic header ?
Yes, or move the definition into its own header, with the default for
*future* architectures (not the majority of the current architectures)
in the header in the sysdeps/unix/sysv/linux directory.
Thanks,
Florian