This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-snps-arc at lists dot infradead dot org>, <alistair dot francis at wdc dot com>, <alistair23 at gmail dot com>
- Date: Tue, 25 Feb 2020 00:09:53 +0000
- Subject: Re: [PATCH v2] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- Ironport-sdr: idAW57AC1hJgxReerhCDgKiL8pwd4zQsJXD/cbOGu9SNrP9eghMo1i/PNsg68gYCA4K3iuQHLC 963tBDXh0p4EoFuuXN4r+Xo9F4GiJI+sYS2XE0oQixBnypq3WoQYy1kwFF/rjDV8jNQiLMesiB Vyhy0ClxwMwfGcGZU+cHFgN5lRk8+sd91uvsTNwIMWcnlNI5+r+tRZZlJmScNj5ocydW+I1xAM 6wGhaVhZ0t5EHmy1bHZt/GT+WQpk8LKrDp+N3+k70c6taXZ4muwWyjhgkgBWAQOyjQ0oCWhkso T0k=
- Ironport-sdr: EN08O+pCdCTZe/xsDFPpBJBABBN3Cun7S4ajaKr0gIaQidBz1eVtsx4pU2IWQekDJt+iD3us2w ldz0bbhcUA41dlB/HOPuPI/3e7xr4bZ+tQgrq5N0jfoDE7l1tf/o3BqXdDpDEgon758jWXbec6 JOvkp4a6Qmq6RxN0XG3QH+Bgf6D21kyY5MRDS/MpOI/cnQQfZFWmeViVsRNSbbib34i3dBMYk1 vR5Dy7o3tZl5eCqFgXwJPDaA9HYTKdjeW0ia0ixiITn1b5lqGI0czgbXa18A3DQ3NCbT3rygWI Gxs=
- References: <87pne3lqrh.fsf@oldenburg2.str.redhat.com> <20200224221530.12928-1-vgupta@synopsys.com>
On Mon, 24 Feb 2020, Vineet Gupta wrote:
> diff --git a/sysdeps/unix/sysv/linux/fxstat64.c b/sysdeps/unix/sysv/linux/fxstat64.c
> index 9133a0a29b8e..93394c450f1c 100644
> --- a/sysdeps/unix/sysv/linux/fxstat64.c
> +++ b/sysdeps/unix/sysv/linux/fxstat64.c
> @@ -33,15 +33,15 @@ int
> ___fxstat64 (int vers, int fd, struct stat64 *buf)
> {
> int result;
> -#ifdef __NR_fstat64
> - result = INLINE_SYSCALL (fstat64, 2, fd, buf);
> -#else
> +# if STAT64_IS_NOT_KERNEL_STAT64 || !defined(__NR_fstat64)
I don't think the extra space after "#" is correct here. We use such
spaces to indicate the level of nesting inside outer #if conditionals, but
there is no outer #if conditional around this one in this file, so "#if"
without the space is correct.
There should be a space before '(' in the "defined" call.
Likewise in other files changed by this patch.
--
Joseph S. Myers
joseph@codesourcery.com