This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: ELF_INITFINI for ARC (was Re: [PATCH] Introduce <elf-initfini.h> and ELF_INITFINI for all architectures)
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, arcml <linux-snps-arc at lists dot infradead dot org>, Alistair Francis <alistair dot francis at wdc dot com>
- Date: Wed, 26 Feb 2020 20:02:16 +0000
- Subject: Re: ELF_INITFINI for ARC (was Re: [PATCH] Introduce <elf-initfini.h> and ELF_INITFINI for all architectures)
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMP23MqVrFYCGomTCpc3ieZt6KpmctXXK0+FLqRV+FQ=; b=ejOvHHYUsHRLC6UCPkE10KfT2h0OY0ADEopPouQqV+xq3Uc7aKUwPa3NV8LACypq9o18SE2aFB3u6myL0TQx0jcDfhUI70eD2oOD4wZcG1AeW1SkmYLGklYXfYp1BaMaZtgTBeOflYwozj+I28Z9RVBCD9UnWTbftoXtKUjrPTRFRqi+HdWn+BodiHwMgE8mHQSgnYwQKPDsFYgmDvOTOoAepMj2nKzWhmWb4+VZjXHZcGqYRBoIh8JQ37XmpRjpJbIn5UMr7UueG6LTtF2J0s70GGn3MYQOs/uaeiu/DTGcyFcEOyZrEscnEvMCss8pwkxtnJ8RRnj1tJmbdZsElg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lv81WQRIH1oZeWhNnc5XS5kwmwsvKqpkUqNUUpt6iHeHp0zwMlP4nIDte2C+HCDf8ymwNWlRpU46dej+xbjFxGck6dBI4dLi3tcnAc5BBxKfLfpOLMWKVDSlj4XPk0F0WbEY0mW3YM4I0Suz87ouVod7NffWGhJphEdUC92ASZh3b3xGacV12fZnS5R973/AVUsjlQ6mf7vIJVybWjPADgBwhmuv6DXY9vpLISHdHFsI6RXTlS8LYesefdns4bkveRa1eW2IUBnHWAviYN6ElBg/RW0r3+gWeQKpnQMo+7j6yux4Z3sCtgudM267WAnQU/l+/5xPLuQ8Wqraz7rxNQ==
- References: <87zhfngjot.fsf@oldenburg2.str.redhat.com> <mvm36b51ahf.fsf@suse.de> <871rqpfc07.fsf@oldenburg2.str.redhat.com> <mvmmu9dyyi8.fsf@suse.de> <87r1ypdrhj.fsf@oldenburg2.str.redhat.com> <cc69bcb6-526a-469d-f78a-035208645ae9@synopsys.com> <87y2sp174p.fsf@oldenburg2.str.redhat.com>
On 2/26/20 11:27 AM, Florian Weimer wrote:
> I haven't followed the ARC contribution process closely, sorry. Do you
> plan to contribute the port with a GLIBC_2.32 ABI baseline, or do you
> want to support older binaries for an earlier non-upstream port,
> backdating the baseline?
No we don't need to support old binaries: 2.32 will be baseline
> This matters because in the GLIBC_2.32 case, old binaries will not work
> anyway, so we may as well require that they are rebuilt without
> DT_INIT/DT_FINI. In this case, the glibc master defaults should work.
Understood !
> If you want to support old binaries (which use older symbol versions
> such as GLIBC_2.17), it may make sense to keep DT_INIT/DT_FINI support
> as well. To achieve this, you need to add an <elf-initifini.h> header
> file with
>
> /* Enable DT_INIT/DT_FINI support. */
> #define ELF_INITFINI 1
>
> and keep the crti.S and crtn.S files you already have.
Per the review comments on ARC port last year [1], I was advised to remove the ARC
specific crt*.S so those are anyhow gone.
[1] https://sourceware.org/ml/libc-alpha/2019-01/msg00654.html