This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/15] nios2: Use Linux kABI for syscall return
On 20/02/2020 18:04, Vineet Gupta wrote:
>
> Through a maze of defines this ends up calling INTERNAL_SYSCALL_RAW which seems be
> unconditionally converting !0 value (success) into -ve and returning it. So won't
> it convert a legit brk address return into a -ve and save in __curbrk.
> On 2/20/20 12:39 PM, Vineet Gupta wrote:
>> Am I not following this correctly ?
>
> Oh never mind, they use 2 seperate regs to convey syscall result and error, so
> your code is right.
>
One of my goals is to disentangle the {INTERNAL,INLINE}_SYSCALL macros
to consolidate their definitions and move the arch-specific bits to
inline functions instead of macros. Another one is to remove the
requirement to define similar assembly macros to be used by the
auto-generated one.
The idea is an architecture will just need to define a set of
inline_syscall{0-6} functions.