This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 25/26] m68k: getpagesize syscall number is always available



On 09/02/2020 17:21, Florian Weimer wrote:
> Due to the built-in tables, __NR_getpagesize is always defined.

LGTM, thanks. 

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/unix/sysv/linux/m68k/getpagesize.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/m68k/getpagesize.c b/sysdeps/unix/sysv/linux/m68k/getpagesize.c
> index ad6559320e..2e419af0e5 100644
> --- a/sysdeps/unix/sysv/linux/m68k/getpagesize.c
> +++ b/sysdeps/unix/sysv/linux/m68k/getpagesize.c
> @@ -28,20 +28,16 @@
>  int
>  __getpagesize (void)
>  {
> -#ifdef __NR_getpagesize
>    int result;
> -#endif
>  
>    if (GLRO(dl_pagesize) != 0)
>      return GLRO(dl_pagesize);
>  
> -#ifdef __NR_getpagesize
>    INTERNAL_SYSCALL_DECL (err);
>    result = INTERNAL_SYSCALL (getpagesize, err, 0);
>    /* The only possible error is ENOSYS.  */
>    if (!INTERNAL_SYSCALL_ERROR_P (result, err))
>      return result;
> -#endif
>  
>    return 4096;
>  }
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]