This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/6] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions




On 2/24/20 8:58 AM, Paul E Murphy wrote:


On 2/3/20 3:10 PM, Paul E. Murphy wrote:
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

Modify the headers to redirect long double functions to global __*f128
symbols or to __*ieee128 otherwise.

Most of the functions in math.h benefit from the infrastructure already
available for __LDBL_COMPAT.  The only exceptions are nexttowardf and
nexttoward that need especial treatment.

Both math/bits/mathcalls-helper-functions.h and math/bits/mathcalls.h
were modified in order to provide alternative redirection destinations
that are essential to support functions that should not be redirected to
the same name pattern of the rest of the functions, i.e.: __fpclassify,
__signbit, __iseqsig, __issignaling, isinf, finite and isnan, which will
be redirected to __*f128 instead of __*ieee128 used for the rest.
---
  include/math.h                                |  9 ++-
  math/bits/mathcalls-helper-functions.h        | 18 +++---
  math/bits/mathcalls.h                         |  9 ++-
  math/math.h                                   | 59 ++++++++++++++++++-
  .../ieee754/ldbl-128ibm/bits/iscanonical.h    |  8 ++-
  5 files changed, 85 insertions(+), 18 deletions(-)

I think the majority of this patch is OK.  My only contribution was to fixup against the deprecation of the finite entry points.

The naming of the nexttoward ABI is a bit awkward, but I proffer no better solutions.

If there are no requests for improvement, or objections, I will commit this and the following patch 4, the equivalent support for complex.h, on Friday.


And committed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]