Re: [PATCH 5/7] ldbl-128ibm-compat: enforce ibm128 on compat tests

[Paul E Murphy <murphyp at linux dot ibm dot com>]

On 2/27/20 4:45 PM, Paul E Murphy wrote:
> On 2/27/20 2:39 PM, Tulio Magno Quites Machado Filho wrote:
> > "Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> >
> > > For lack of a more comprehensive solution, tack on the ibm128 ABI
> > > compiler options for the totalorder{,mag}l compat tests which exist
> > > prior to enabling this feature.
> > > ---
> > >   sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 10 ++++++++++
> > >   1 file changed, 10 insertions(+)
> > >
> > > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile 
> > > b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> > > index e40ae08469..af8027cf0e 100644
> > > --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> > > +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> > > @@ -270,6 +270,7 @@ tests-internal += tst-ibm128-error tst-ieee128-error
> > >   tests-internal += tst-ibm128-efgcvt tst-ieee128-efgcvt
> > >   $(objpfx)tst-ieee128-efgcvt: gnulib-tests += $(f128-loader-link)
> > > +$(objpfx)tst-ldbl-efgcvt: gnulib-tests += $(f128-loader-link)
>
> I agree and missed this when refactoring patches.  It has been moved 
> into a separate patch.
>
> > LGTM, but I think this test should mentioned in the commit message too.
> >
> > Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

Committed and trivial one-liner moved to a second commit and committed.