This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S390: Remove backchain-based fallback and use generic backtrace.c.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stefan Liebler <stli at linux dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 04 Mar 2020 16:24:26 +0100
- Subject: Re: [PATCH] S390: Remove backchain-based fallback and use generic backtrace.c.
- References: <20200304150330.3054553-1-stli@linux.ibm.com>
* Stefan Liebler:
> After recent discussions:
> - "[PATCH] s390: Remove backchain-based fallback from backtrace"
> https://www.sourceware.org/ml/libc-alpha/2020-02/msg00287.html
>
> - "Re: [PATCH 07/11] s390: Implement backtrace on top of <unwind-link.h>"
> https://www.sourceware.org/ml/libc-alpha/2020-02/msg00637.html
>
> We've checked and decided to remove the backchain:
> We don't know of any environments without libgcc. Thus the backchain
> unwinder is not used. If somebody builds with -mbackchain and without
> fasynchronous-unwind-tables and has libgcc installed, then the
> libgcc unwinder is called but not the backchain-based fallback.
>
> This step allows to get rid of the s390x specific backtrace.c files at all.
> Furthermore the now used debug/backtrace.c version has some more
> advantages:
> - Free all resources if necessary. (libc_freeres_fn)
> - Remove NULL address above _start.
> - Check whether we make any progress while getting addresses.
Looks good to me. Thanks for doing this.
Florian