This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros

From: Florian Weimer <fweimer at redhat dot com>
To: Matheus Castanho <msc at linux dot ibm dot com>
Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Date: Wed, 04 Mar 2020 18:47:13 +0100
Subject: Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
References: <20200303182038.6873-1-msc@linux.ibm.com> <249905ba-8a9e-8a10-5450-070a4045e8c9@linaro.org> <874kv4a2vr.fsf@oldenburg2.str.redhat.com> <5b2a8ddc-edae-b0fa-ed21-284a155bdb59@linux.ibm.com>

* Matheus Castanho:

>> __builtin_popcount (e) == 1 does not
>> seem to be unreasonable to express this condition.
>> 
>
> Adhemerval and Florian, apart from the discussion to remove or not
> fenvinline.h altogether, could we push this commit? This header is
> currently in a broken state and I'd like to fix it for the time being.

I think the patch is okay, but please also wait for Adhemerval's
comments.

I'd also be okay with powerof2 and a zero check.  I agree that we should
fix this soon.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
  - From: Adhemerval Zanella

References:
- [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
  - From: Matheus Castanho
- Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
  - From: Adhemerval Zanella
- Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
  - From: Florian Weimer
- Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros
  - From: Matheus Castanho

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]