This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] linux: Add soft-fp folder for arm with --without-fp
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 5 Mar 2020 00:55:28 +0000
- Subject: Re: [PATCH] linux: Add soft-fp folder for arm with --without-fp
- Ironport-sdr: AGbqYk6BLMLe816FZRNCnZeafXIzu9Icn+54DJmmAtMm/Fe43H6ahg6R+vyShk6nngfG0+rtPx vLnVdLkVfsaYDkHy78H1v07Y2QRJ/efRqCULzhZiWVtZL6EJ4fzPJ9xO4lZdfQdgo5wtHPS0P3 e9N1TpDI2+XgKhxnLiF39aPuQgtYHhzJfxb2CLAp/xjvvDZk9wliKjc6HKPUBuV9V5N7A38ATD mPkMMkjt43Uw2sfSIBOBtQtqssvX6EepEKe+zQPBHH8LyCNTtYcxVaN10Ydn57cEb4q7CB7Zbp jpI=
- Ironport-sdr: GAGemn+C/yQ0mGnqEvRJtf+N1FasdQr0ddEeyB33C9tNfQfiji/yyphcj/zdmlSh4aTUGNaWds pC5B0xT77DatTiWO6ZO/yUxsTTwH2kHdALQNBhAMq++CLbXgTLoQQacsqtKiWQ0Ump9MwmcF5N Z9Lbmp0ATL5bL91jXyT8vSRRb6mREdq2d18hcSoLxLvfaxDrjv9JgiWvQpLm6fmqZEEYMq4czE 1p/OTXV3TfAQLQmkMRaT3NSZpEsWhhrBBad5mwGY8ixQpUzglYHE5jrBxBgco576/B1+Us9FW0 SyI=
- References: <20200304171105.24573-1-adhemerval.zanella@linaro.org>
On Wed, 4 Mar 2020, Adhemerval Zanella wrote:
> Currently --without-fp does not add the soft-fp folder before
> the generic dbl-64 and flt-32 on arm-linux-gnueabi. This patch adds
> the required Implies file (similar as powerpc, mips32, and
> m68k-coldfire have done).
There hasn't been a --without-fp configure option since commit
8df5d34720dd71e934545bade879e04697830757, so this commit message is
clearly wrong.
Based on disassembling a 2.27 binary (2.27 being the first release after
the sysdeps/ieee754/soft-fp directory was added), the sysdeps ordering was
working then, but I confirm it's broken now. Thus this raises the
question of when the ordering broke, and thus (a) whether it might have
broken for any other configurations using sysdeps/ieee754/soft-fp at the
same time, and thus need fixing for them, (b) whether the breakage broke
ordering for anything other than nofpu directories and (c) whether it
might need a bug filed in Bugzilla if the issue was present in a release.
The addition of /le sysdeps directories is one change that might have had
a risk of breaking such ordering, but I don't know if it was that or not.
--
Joseph S. Myers
joseph@codesourcery.com