This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 2/2] x86_64: roundeven with fpu and sse4.1 support
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Shen-Ta Hsieh <ibmibmibm dot tw at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 5 Mar 2020 01:20:28 +0000
- Subject: Re: [PATCH v3 2/2] x86_64: roundeven with fpu and sse4.1 support
- Ironport-sdr: jS/gCRpqdklSQoj0Za1EUZr3DBjvQbZgGRIPEF2DC6G5zEyTG0ALeMp0Ng2CYiQhqRhRNqSCAB nJPceyriTN08uy/q0PhHpnDy67tMLoeO7geVLSa0UpQRhiNGW0Yxs3kN+yBIopTjw3OLj7ghBn t8/vUft0pPLMhfzV4kTngVewfjtJhQjalop1x0uYR77CZ20hAbaCV903A2jRW8FwrXJnCGud9+ JWDqZjmuGuDxktNri0Xy3u+7nf2rU/jGfWyXr2WGRVJTx6SXSb9OjldzSqRt+zPqA5ZRfKjkQ/ Q9c=
- Ironport-sdr: 7OCKn2NZ3FXrZrd9U4RoanvBASwdD6pDCv4lLWRhsxcK5y1HdqZtKJUdkm+9V6B4yBeHxuFl6V VQXbayfFzoOWEIOJOaaV3mxfYt0cxz13Nb46/TRY1/qijOlznYBGz/VXYnohYmyBLgwTdEEH9k D4yabH8p7Abn+N+QQOltfhpDA3SvRipkGppRnTnuImMOSUKbQoJwr8NMc213ijliOEks8UFfR1 cO3f4cJOa189lowD/A3U+T8TZ25wWxIDiKDOC5Kng3CqqVW+K8YkAsGbOjedC7NRnUbq49jy4O bi4=
- References: <20191214161138.4134889-1-ibmibmibm.tw@gmail.com> <20191216012634.3235777-2-ibmibmibm.tw@gmail.com>
Generally such architecture-specific function versions should be justified
with benchmark results showing a performance improvement.
That is, first you should add benchmark inputs for the roundeven functions
in benchtests/. Then patches adding architecture-specific roundeven
implementations should include before-and-after benchmark results in the
commit message to demonstrate that the architecture-specific
implementation does indeed result in a performance improvement.
Note also the need for an FSF copyright assignment for significant
contributions:
https://sourceware.org/glibc/wiki/Contribution%20checklist#FSF_copyright_Assignment
--
Joseph S. Myers
joseph@codesourcery.com