This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Remove fenvinline.h
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc: Segher Boessenkool <segher at kernel dot crashing dot org>, William J. Schmidt <wschmidt at linux dot ibm dot com>, Michael Meissner <meissner at linux dot ibm dot com>
- Date: Fri, 06 Mar 2020 15:08:08 -0300
- Subject: Re: [PATCH] math: Remove fenvinline.h
- References: <20200306175424.19827-1-adhemerval.zanella@linaro.org>
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> Similar to string2.h (18b10de7ce) and string3.h (09a596cc2c) this
> patch removes the fenvinline.h on all architectures. Currently
> only powerpc implements some optimization.
>
> As for the strings optimization, this kind of optimization is
> better implemented by the compiler (which handles the architecture
> ISA transparently).
>
> Also, for the specific optimized powerpc implementation the code is
> becoming convoluted and these micro-optimization are hardly wildly
> used, even more being a possible hotspot in realword cases
> (non-default rounding are used only on specific cases and exception
> handling are done most likely only on errors path). The fact
> that no other architecture bother to implement such optimization
> is also an indication that these should no be on libc.
>
> The math/test-fenv already covers all math/test-fenvinline tests,
> so it is safe to remove it.
>
> Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.
As has been mentioned in the previous thread [1]: I welcome this patch after the
proposed compiler features are implemented, but I don't think glibc
should remove fenvinline.h before that.
[1] https://www.sourceware.org/ml/libc-alpha/2020-03/msg00073.html
--
Tulio Magno