This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Remove fenvinline.h
- From: Paul E Murphy <murphyp at linux dot ibm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Fri, 6 Mar 2020 13:36:34 -0600
- Subject: Re: [PATCH] math: Remove fenvinline.h
- References: <20200306175424.19827-1-adhemerval.zanella@linaro.org>
On 3/6/20 11:54 AM, Adhemerval Zanella wrote:
Similar to string2.h (18b10de7ce) and string3.h (09a596cc2c) this
patch removes the fenvinline.h on all architectures. Currently
only powerpc implements some optimization.
Is that entirely accurate? x86 looks like it places similar inline
optimizations into bits/fenv.h, i.e feraiseexcept.
Should these instead move into the equivalent ppc bits/fenv.h header?
As for the strings optimization, this kind of optimization is
better implemented by the compiler (which handles the architecture
ISA transparently).
Also, for the specific optimized powerpc implementation the code is
becoming convoluted and these micro-optimization are hardly wildly
used, even more being a possible hotspot in realword cases
(non-default rounding are used only on specific cases and exception
handling are done most likely only on errors path). The fact
that no other architecture bother to implement such optimization
is also an indication that these should no be on libc.
The math/test-fenv already covers all math/test-fenvinline tests,
so it is safe to remove it.