This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-snps-arc at lists dot infradead dot org>
- Date: Sat, 7 Mar 2020 00:19:53 +0000
- Subject: Re: [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc
- Ironport-sdr: T7UiZFU7u+YEtk9WJp0MA+oaSSr0/bNlUr7BeubdOMwXBIgr+EOXOYcVHnob3DHDR9L2Hzr2qF pp2oHJ+TKoY+vxBBEIJEbE194mJ5LcsV4f5st8KsvAmPVT6TEiQpb00sCw1IJL3frpPrcUq+Cd yx6hSm6z2JtkRMMzZTVYwT6Q6usS7DMgt0pMo8yL2Wc0qqiwsk4aSD8QpR+KlyEBil+D+KdJaQ TwN7g5UWYnHCc79Fhc134n5cPn9G/sJvlGJiOVLja+pNtDLjrf4O/zUtAn6OcpPQF1qaBuHgkX t18=
- Ironport-sdr: 3S+TyJ7yK5MhJ8z2RL/qG4Tuj/6uZEJdkdtFg2tVuKoAGWL6BpZLoz2lkty8sxnUlPIlTBi9AQ U+6pBwTHqF80xwH+HB/BGh7oqxbPMNMiCbWpL/fsXwTCI8W0uQxq2DyI74ckWAMIo0yOLDpjm2 XD/gm1YFJnppSFKPyyUzrLrxKBAIyV0v0d0ZyccRAUXgnjCMKGlWsmfY0sT8GJYvsNAIneSII+ xTJuGN52v7FUVPc6I5BCkmsZ8OzkM9eMFjyX2N7AQnyjMaUnCKdUVgWb00TwOQ6FfLeOzBPESi yKs=
- References: <20200306182419.13945-1-vgupta@synopsys.com> <20200306182419.13945-18-vgupta@synopsys.com>
On Fri, 6 Mar 2020, Vineet Gupta wrote:
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> .../sysv/linux/arc/bits/socket-constants.h | 4 +--
There is a general principle for patch series: you should not have later
patches fixing up things that were wrong with earlier patches. Each patch
should add files in the form desired to be reviewed, not in a form that
gets fixed up later.
(Sometimes a patch series might change a file that was correct in an
earlier patch in the series, as part of adding additional features, if the
first M patches add feature X and the next N add feature Y on top of it.
But that's not the case here - such later patches should not make
incompatible changes to earlier ones.)
--
Joseph S. Myers
joseph@codesourcery.com