[PATCH v3 2/3] y2038: linux: Provide __mq_timedsend_time64 implementation

Lukasz Majewski lukma@denx.de
Mon Mar 9 10:00:01 GMT 2020


Hi Andreas,

> On Mär 06 2020, Lukasz Majewski wrote:
> 
> > Hi Andreas,
> >  
> >> On Mär 04 2020, Lukasz Majewski wrote:
> >>   
> >> > diff --git a/include/mqueue.h b/include/mqueue.h
> >> > index 3c66f1711e..81d30dbdf7 100644
> >> > --- a/include/mqueue.h
> >> > +++ b/include/mqueue.h
> >> > @@ -10,4 +10,13 @@ extern __typeof (mq_timedreceive)
> >> > __mq_timedreceive __nonnull ((2, 5)); hidden_proto
> >> > (__mq_timedreceive) hidden_proto (mq_setattr)
> >> >  # endif
> >> > +#if __TIMESIZE == 64
> >> > +# define __mq_timedsend_time64 __mq_timedsend
> >> > +#else
> >> > +# include <bits/types/struct___timespec64.h>    
> >> 
> >> I think the header should be included unconditionally.
> >>   
> >
> > The idea behind adding the struct___timespec64.h header only for
> > "#else" clause was that it is not needed at all when we do have
> > archs with __TIMESIZE == 64.  
> 
> The problem is that it changes the set of included headers depending
> on configuration.

I see - thanks for the clarification.

Just to be 100% sure - is it required for "internal" glibc headers to
have the same set of included headers ?

I mean the struct___timespec64.h is included in ./include/mqueue.h,
which is not exported set of headers (to say in other words - it is
local to built glibc).

> 
> Andreas.
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20200309/cb5ddad9/attachment.sig>


More information about the Libc-alpha mailing list