[RFC PATCH glibc 1/8] Introduce <elf_machine_sym_no_match.h>
H.J. Lu
hjl.tools@gmail.com
Mon Mar 23 14:51:04 GMT 2020
On Mon, Mar 23, 2020 at 6:18 AM Mathieu Desnoyers via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> From: Florian Weimer <fweimer@redhat.com>
>
> MIPS needs to ignore certain existing symbols during symbol lookup.
> The old scheme uses the ELF_MACHINE_SYM_NO_MATCH macro, with an
> inline function, within its own header, with a sysdeps override for
> MIPS. This allows re-use of the function from another file (without
> having to include <dl-machine.h> or providing the default definition
> for ELF_MACHINE_SYM_NO_MATCH).
>
> Built with build-many-glibcs.py, with manual verification that
> sysdeps/mips/elf_machine_sym_no_match.h is picked up on MIPS. Tested
> on aarch64-linux-gnu, i686-linux-gnu, powerpc64-linux-gnu,
> s390x-linux-gnu, x86_64-linux-gnu.
>
> * elf/elf_machine_sym_no_match.h: New file.
> * elf/dl-lookip.c (ELF_MACHINE_SYM_NO_MATCH): Do not define.
> * elf/dl-lookup.c (check_match) Call elf_machine_sym_no_match
> instead of ELF_MACHINE_SYM_NO_MATCH.
> * sysdeps/mips/dl-machine.h (ELF_MACHINE_SYM_NO_MATCH): Remove
> definition.
> * sysdeps/mips/elf_machine_sym_no_match.h: New file. Extracted
> from sysdeps/mips/dl-machine.h.
Why not sysdeps/generic/elf_machine_sym_no_match.h? It matches
sysdeps/mips/elf_machine_sym_no_match.h better.
--
H.J.
More information about the Libc-alpha
mailing list