[PATCH v4 07/15] ARC: hardware floating point support
Vineet Gupta
Vineet.Gupta1@synopsys.com
Fri Mar 27 18:53:53 GMT 2020
On 3/27/20 11:37 AM, Joseph Myers wrote:
> feupdateenv has to preserve the previously raised exceptions even in the
> FE_DFL_ENV case. It's equivalent to
>
> exc = fetestexcept (FE_ALL_EXCEPT);
> fesetenv (envp);
> feraiseexcept (exc);
Ok.
>> In some places I have following:
>>
>> if (((fpcr >> __FPU_RND_SHIFT) & FE_DOWNWARD) != round)
>>
>> So FE_DOWNWARD (0x3) is used as mask, is that OK or would you rather see
>>
>> #define __FPU_RND_MASK 0x3
>
> I think it's cleanest to have a separate define for the mask.
OK.
More information about the Libc-alpha
mailing list