This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] kprobes patch
- From: Keshavamurthy at bambi dot jf dot intel dot com, Anil S <anil dot s dot keshavamurthy at intel dot com>
- To: Jun Koi <junkoi2004 at gmail dot com>
- Cc: prasanna at in dot ibm dot com, jkenisto at us dot ibm dot com, hien at us dot ibm dot com, systemtap at sources dot redhat dot com
- Date: Fri, 27 Oct 2006 13:50:28 -0700
- Subject: Re: [PATCH] kprobes patch
- References: <fdaac4d50610271158w20f296cdw8beb48b624115867@mail.gmail.com>
- Reply-to: Keshavamurthy at bambi dot jf dot intel dot com, Anil S <anil dot s dot keshavamurthy at intel dot com>
On Sat, Oct 28, 2006 at 03:58:18AM +0900, Jun Koi wrote:
> Hello,
>
> I am not sure if this is a right place to send patch for kprobes, but
> here it is. This patch moves the reset command of kprobe instance
> into the loop. (against 2.6.18)
Hi jun,
Yes, you have sent it to the right place. thanks.
BTW, is is helpful to know what problem did you encounter due to which
you had come up with this patch. Or did you catch this bug by just code review?
>
>
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
>
>
> --- a/kernel/kprobes.c 2006-09-20 12:42:06.000000000 +0900
> +++ b/kernel/kprobes.c 2006-10-28 03:52:27.000000000 +0900
> @@ -204,8 +204,8 @@ static int __kprobes aggr_pre_handler(st
> set_kprobe_instance(kp);
> if (kp->pre_handler(kp, regs))
> return 1;
> + reset_kprobe_instance();
> }
> - reset_kprobe_instance();
> }
> return 0;
> }