Re: [patch] Alter syscall.brk and syscall.mremap to support IA64

[Lai Jiangshan <laijs at cn dot fujitsu dot com>]

Lai Jiangshan wrote:
> Wenji Huang wrote:
> > Lai Jiangshan wrote:
> >
> > > Hi, all
> > >     In the current tapset, kernel function sys_brk and sys_mremap are
> > > used to probe syscall.brk and syscall.mremap. But on IA64, the entries
> > > of syscall brk and mremap are actually ia64_brk and ia64_mremap, but not
> > > sys_brk and sys_mremap. Though I think ia64's kernel function will be
> > > finally changed to sys_brk and sys_mremap, it will be a long time so it
> > > is inconvenient for users to probe these 2 syscalls on IA64. So I added
> > > the probe points to syscall.brk and syscall.mremap for IA64 as 
> > > following:
> > > ......
> >
> > sys_brk is generic, use %( arch == "ia64" %? to make it optional. Of 
> > course, it is better to put architecture depended probe into the 
> > corresponding directory.
>
>  ......
>
>    So, I think it will be better to modify the tapset in my way.

Hi, all
   I will ask zhaolei to commit it if there is no more objection.

   This patch has no any bad effect to current tapset. It just like adding
following code in c. It is of no effect even if the "condition" cannot be
true someday.

   if (condtion) {
       do_something;
   }

Best regards!
Lai Jiangshan