This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
changelog files, %( %) idioms
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: srinivasa at in dot ibm dot com
- Cc: systemtap at sources dot redhat dot com
- Date: Mon, 25 Feb 2008 09:59:15 -0500
- Subject: changelog files, %( %) idioms
Hi -
Please remember to add ChangeLog file entries for patches you commit.
You committed several important fixes that only show up on careful
search of cvs/git logs. Please rescan src/HACKING for guidelines, and
consider retroactively adding the ChangeLog entries.
Thanks for the bug #5772 patch. It is possible to make the %( kernel
%) conditionals look more compact by realizing that they don't operate
at the statement but at the token level. That means one can use them
around just the smallest bit of code that needs to be changed for
different versions/architectures, so that instead of:
%( kernel_vr > "2.6.24" %?
argstr = sprintf("%d, %p, %s, %p", $upid, $stat_addr, _wait4_opt_str($options), $ru)
%:
argstr = sprintf("%d, %p, %s, %p", $pid, $stat_addr, _wait4_opt_str($options), $ru)
%)
and
%( kernel_vr > "2.6.24" %?
pid = $upid
%:
pid = $pid
%)
one could write ...
argstr = sprintf("%d, %p, %s, %p",
%( kernel_vr > "2.6.24" %? $upid %: $pid %),
$stat_addr, _wait4_opt_str($options), $ru)
and
pid = %( kernel_vr > "2.6.24" %? $upid %: $pid %)
- FChE