This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]Add lacked syscall.unshare to tapset


Hello, Mark

>> It is different from flags in __fork_flags.
>> I think it maybe necessary to add a new function like __unshare_flags in
>> aux_syscalls.stp.
> 
> If I read that fragment above correctly then not all the same flags are
> supported, but you can still call unshare with them. The result will
> just be that the syscall fails (because it doesn't support that
> particular flag). So I don't think you need new function.
I checked the difference between __fork_flags and sys_unshare.
Nearly all unshare flags are supported by __fork_flags except CLONE_NEWUTS
and CLONE_NEWNET. They should be __fork_flags too.

What if I add CLONE_NEWUTS and CLONE_NEWNET into __fork_flags function and
use __fork_flags in probe syscall.unshare?

Best Regards
Zhaolei

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]