This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [Patch 2/2] Enhancements to vfs.stp (with minor modifications)

From: "Stone, Joshua I" <joshua dot i dot stone at intel dot com>
To: <prasad at linux dot vnet dot ibm dot com>, <systemtap at sources dot redhat dot com>
Cc: <mmlnx at us dot ibm dot com>
Date: Mon, 9 Jun 2008 11:10:08 -0700
Subject: RE: [Patch 2/2] Enhancements to vfs.stp (with minor modifications)
References: <20080528105210.GA27784@in.ibm.com> <20080528105829.GB28111@in.ibm.com> <y0mhccibe6q.fsf@ton.toronto.redhat.com> <20080609113837.GB1810@in.ibm.com>

K.Prasad wrote:
> +function __address_inode:long (page:long) %{ /* pure */
> +	struct page *page = (struct page *)(long)THIS->page;
> +	struct address_space *mapping =
> +			(struct address_space *)(long)THIS;

This typecast looks extremely suspect...

Josh

Follow-Ups:
- Re: [Patch 2/2] Enhancements to vfs.stp (with minor modifications)
  - From: K.Prasad

References:
- [RFC Patch 0/2] VFS tapset patches
  - From: K.Prasad
- [RFC Patch 2/2] Enhancements to vfs.stp
  - From: K.Prasad
- Re: [RFC Patch 2/2] Enhancements to vfs.stp
  - From: Frank Ch. Eigler
- [Patch 2/2] Enhancements to vfs.stp (with minor modifications)
  - From: K.Prasad

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]