Re: [PATCH] don't generate empty struct global

[Josh Stone <jistone at redhat dot com>]

Wenji Huang wrote:
> Impact: clean up
>
> struct global will keep the defined global variables. It will be 
> generated but no reference even no global variables. like,
>
> static struct {
> } global = {
>
> };

Have you seen any actual impact of keeping this?  It doesn't seem to be 
included in the final module as far as I can see.

> This patch will skip the struct if no global variable.

That said, your change looks fine to me.  Just tweak it to follow the 
GNU coding style please.

  if (...)
    {
      ...
    }



Josh