[Bug translator/10849] make MAXSKIPPED overflow trigger an error message

["chwang at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

------- Additional Comments From chwang at redhat dot com  2009-10-28 18:20 -------
Created an attachment (id=4333)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4333&action=view)
Simplified patch

(In reply to comment #2)
> The second hunk (the _stp_error() call) should do the trick; the first
> (just setting c->last_error) probably doesn't do what you want here.
> 
> Can you describe your testing?
> 

Roland and I tried setting the MAXUPROBES and MAXSKIPPED directives to force
SystemTap to trigger the MAXSKIPPED error message seems to work for testing
purposes. The current proposal should print the error message once if the
number of skipped probes ever exceeds MAXSKIPPED.

Command:
stap -DMAXSKIPPED=0 -DMAXUPROBES=0 -c 'userBin' userScript.stp

Where userScript.stp probes a number of functions in the target binary.

Results:
ERROR: Skipped too many probes, check MAXSKIPPED or try again with stap -t for
more details.
WARNING: Number of errors: 0, skipped probes: 26

[result of probe begin, if any]

Attached a version of the patch (generated via git diff) with only the single
line of code inserted :)

-Charley

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10849

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.