This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] [PATCH 2.6.37-rc5-tip 18/20] 18: uprobes: commonly used filters.
- From: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- To: Valdis dot Kletnieks at vt dot edu
- Cc: Peter Zijlstra <peterz at infradead dot org>, Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Andi Kleen <andi at firstfloor dot org>, Christoph Hellwig <hch at infradead dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, SystemTap <systemtap at sources dot redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>
- Date: Sat, 18 Dec 2010 08:34:03 +0530
- Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 18/20] 18: uprobes: commonly used filters.
- References: <20101216095714.23751.52601.sendpatchset@localhost6.localdomain6> <20101216100049.23751.2658.sendpatchset@localhost6.localdomain6> <51253.1292614379@localhost>
- Reply-to: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
* Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> [2010-12-17 14:32:59]:
> On Thu, 16 Dec 2010 15:30:49 +0530, Srikar Dronamraju said:
>
> > Provides most commonly used filters. Prevents users from having to define
> > their own filters. However this would be useful once we can
> > dynamically associate a filter with a uprobe-event tracer.
>
> Unclear/awkward language here...
>
> Did you mean "Prevents users from defining their own filters" or "Allows
> users to not have to define their own filters"?
The later one. From my perspective, users would prefer to filter
based on tid, pid, sid. So by defining these common/generic filters
within uprobes, we help users from not having to redine these
filters. However it no way prevents users from defining their
filters. Also users can still go ahead and add a filter for the same
purpose for which we already have defined a filter.
If you think user would like to filter based on some other
parameter that most users would be interested, then do let me know,
I will try to add a filter for the same.
--
Thanks and Regards
Srikar