This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add the stopwatch.stp tapset

From: "Frank Ch. Eigler" <fche at redhat dot com>
To: William Cohen <wcohen at redhat dot com>
Cc: systemtap at sourceware dot org
Date: Mon, 30 Jan 2012 13:12:46 -0500
Subject: Re: [PATCH] Add the stopwatch.stp tapset
References: <1327610194-13346-1-git-send-email-wcohen@redhat.com> <y0m7h0e55cf.fsf@fche.csb> <4F26D901.6060403@redhat.com>

Hi, Will -

> One thing missing from the simpler API is a way to clean things up.  [...]
> function delete_stopwatch (name:string) {}

OK, good idea.

> probably should have matching optional that can be explicitly called [...]
> function create_stopwatch (name:string) {}

This one sounds like make-work.  It could be that exact empty function, no?

- FChE

References:
- [PATCH] Add the stopwatch.stp tapset
  - From: William Cohen
- Re: [PATCH] Add the stopwatch.stp tapset
  - From: Frank Ch. Eigler
- Re: [PATCH] Add the stopwatch.stp tapset
  - From: William Cohen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]