This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: systemtap broken by removal of register_timer_hook
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Frederic Weisbecker <fweisbec at gmail dot com>
- Cc: Mel Gorman <mgorman at suse dot de>, Ingo Molnar <mingo at kernel dot org>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sourceware dot org>
- Date: Wed, 03 Apr 2013 08:29:48 -0400
- Subject: Re: systemtap broken by removal of register_timer_hook
- References: <20130403075017 dot GA2534 at suse dot de> <CAFTL4hyYezB2ZxM-GJ70VoxOeRSG64V6u+nX2hTuhF30R-GdPg__32168 dot 962484184$1364986928$gmane$org at mail dot gmail dot com>
Frederic Weisbecker <fweisbec@gmail.com> writes:
> [...]
> Sometimes I don't mind keeping around code in the kernel for out of
> tree users, depending on the case. But in this specific matter we have
> more standard ways to do this kind of hook: kprobes, static
> tracepoints. A tracepoint on the timer tick would be useful BTW, and
> you could reuse it.
Thanks for noticing! IMO kprobes would be too heavyweight for this.
A new static tracepoint would be fine, especially if it passes the
same pt_regs* pointer as the former hook did.
- FChE