This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf
- From: Hemant Kumar <hemant at linux dot vnet dot ibm dot com>
- To: Namhyung Kim <namhyung at gmail dot com>, Andi Kleen <andi at firstfloor dot org>
- Cc: linux-kernel at vger dot kernel dot org, srikar at linux dot vnet dot ibm dot com, peterz at infradead dot org, oleg at redhat dot com, hegdevasant at linux dot vnet dot ibm dot com, mingo at redhat dot com, anton at redhat dot com, systemtap at sourceware dot org, masami dot hiramatsu dot pt at hitachi dot com, aravinda at linux dot vnet dot ibm dot com, penberg at iki dot fi
- Date: Mon, 21 Jul 2014 15:10:26 +0530
- Subject: Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf
- Authentication-results: sourceware.org; auth=none
- References: <20140717054826 dot 19995 dot 61782 dot stgit at hemant-fedora> <20140717055341 dot 19995 dot 97042 dot stgit at hemant-fedora> <87d2d24kui dot fsf at tassilo dot jf dot intel dot com> <87zjg3jv0v dot fsf at sejong dot aot dot lge dot com>
Hi Andi and Namhyung,
On 07/21/2014 08:08 AM, Namhyung Kim wrote:
Hi Andi,
On Fri, 18 Jul 2014 10:50:45 -0700, Andi Kleen wrote:
Hemant Kumar <hemant@linux.vnet.ibm.com> writes:
+/*
+ * Finds out the libraries present in a system as shown by the command
+ * "ldconfig --print-cache". Uses "=>" and '/' to find out the start of a
+ * dso path.
+ */
This seems like a hack. How would that handle chroot, containers
etc. ?
[SNIP]
+/*
+ * Obtain the list of paths from the PATH env variable
+ */
Same as above. This probably needs to be more configurable to handle
more ways to find binaries.
Agreed. What about not to be smart? IOW, just let users specify
directories and/or files to be scanned. Maybe we can use it like:
perf list sdt --scan $PATH
or
perf sdt-cache --scan /lib:/lib64
Agreed, that we need to have options to add more binaries present in
directories other than the default directories.
We can add some wrapper or default directory later if needed.
But wasn't the whole point of changing to this patchset was to make SDT
events more
prominent, i.e., to display the SDTs present in the whole system?
So, what I am trying to say is that, we already have the PATH bins and
libs' dsos, if
we need to add more, we can use :
perf sdt-cache --scan [dir1][:dir2]...
What would you suggest we do?
--
Thanks,
Hemant Kumar