Re: [PATCH 0/2] initscript: add support for uprobes scripts

[Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>]

(2014/08/08 15:33), Stefan Hajnoczi wrote:
> The initscript currently fails for user-space probing scripts on systems where
> uprobes.ko is built from source by stap(1).  This is because the initscript
> uses a two-phase "compile and then run" approach:
> 
> The uprobes.ko module is generated during the compile phase but not copied into
> the cache directory where modules are placed for the run phase.  The staprun(8)
> command fails because the script module cannot be loaded without uprobes.ko.
> 
> These patches address the issue by copying uprobes.ko into the cache directory.
> If a script specifies the -u option in its initscript configuration file,
> staprun(8) will receive the path to uprobes.ko.

These look good to me :-)
BTW, is it still working with systemd?

Thanks!

> 
> There is no change in behavior on systems that do not build uprobes.ko.
> 
> Stefan Hajnoczi (2):
>   initscript: copy uprobes.ko to cache directory
>   initscript: allow scripts to load uprobes
> 
>  initscript/systemtap.in | 24 +++++++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com