This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug tapsets/18650] powerpc variant of longlong_arg() for uprobes swaps the high and low half of its 64bit retval


https://sourceware.org/bugzilla/show_bug.cgi?id=18650

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
The powerpc change seems correct, as can be seen in the following function
prototypes:

asmlinkage int compat_sys_ftruncate64(unsigned int fd, u32 reg4,              
                                      unsigned long high, unsigned long low)  
asmlinkage int compat_sys_truncate64(const char __user * path, u32 reg4,      
                                     unsigned long high, unsigned long low)   

I'd say your patch looks correct.

Up to this fairly recently 'powerpc' has always meant big-endian powerpc. With
the introduction of little-endian powerpc linux support, things have changed.
Have you tried this code work on a ppc64le system?

-- 
You are receiving this mail because:
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]