This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] buildrun: remove quotes around -I include line
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Torsten Polle <Torsten dot Polle at gmx dot de>
- Cc: systemtap at sourceware dot org
- Date: Sat, 06 May 2017 23:34:03 -0400
- Subject: Re: [PATCH] buildrun: remove quotes around -I include line
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fche at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 393EC81235
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 393EC81235
- References: <8F6D5629-06F8-496F-9232-6DA7422511D5@gmx.de>
Torsten.Polle wrote:
> [...]
> > - o << "EXTRA_CFLAGS += -I\"" << s.runtime_path << "\"" << endl;
> > + o << "EXTRA_CFLAGS += -I" << s.runtime_path << endl;
> as I also need this patch, I would like to check on the status. I've
> not seen this patch applied yet. Did I miss something?
The patch would work around an as-yet-unidentified kbuild scripting bug
somewhere, but would break builds with a runtime_path containing spaces.
Maybe that's OK.
- FChE