[Bug translator/22193] Regex matching (=~) should be treated as a side-effecting operation

["serhei.public at gmail dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=22193

Serhei Makarov <serhei.public at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--- Comment #2 from Serhei Makarov <serhei.public at gmail dot com> ---
Actually the earlier commit I made is a bad idea for reasons both tedious and
potentially numerous:

- After this patch, 'unused_var; if (SIDE_EFFECTING_REGEXP_MATCH(unused_var))
{more_unused_stuff}' will force 'more_unused_stuff' to be kept but elide
'unused_var' -- somehow it doesn't pick up that REGEXP_MATCH reads
'unused_var'. For example, see '_af_inet_info_u' in tapset/linux/syscalls.stpm.

- 'embedded_seen' can be referenced in cases that don't make sense for regex:
for example, 'embedded_seen=true' forbids an expression from being used in a
probe condition.

This PR should either be WONTFIXed or these issues should be dealt with, and
the side-effecting state of a regex match should be represented with something
other than 'embedded_seen'. Reverting the patch for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.