Re: mips32 cld change

["Tim Michals" <t dot michals at attbi dot com>]

Jifl,

I've attached and copied the updated version.  Thanks, Tim

Index: hal_mips_mips32.cdl
===================================================================
RCS file:
/cvs/ecos/ecos/packages/hal/mips/mips32/current/cdl/hal_mips_mips32.cdl,v
retrieving revision 1.4
diff -u -5 -p -r1.4 hal_mips_mips32.cdl
--- hal_mips_mips32.cdl 23 May 2002 23:03:31 -0000 1.4
+++ hal_mips_mips32.cdl 4 Jan 2003 11:53:01 -0000
@@ -73,14 +73,31 @@ cdl_package CYGPKG_HAL_MIPS_MIPS32 {

     cdl_option CYGHWR_HAL_MIPS_FPU {
         display    "Variant FPU support"
         calculated 0
     }
+
+   cdl_option CYGHWR_HAL_MIPS_MIPS32_ENDIAN {
+        display       "Endian format to use"
+        flavor        data
+        default_value {"Little" }
+        legal_values  {"Little" "Big" }
+        description   "
+            The MIPS 32 can use either a big or little endian format.
+            This allows the flexibility to choose which format to use
+     to create a HAL."
+    }

     cdl_option CYGPKG_HAL_MIPS_LSBFIRST {
         display    "CPU Variant little-endian"
-        calculated 1
+        calculated {   CYGHWR_HAL_MIPS_MIPS32_ENDIAN == "Little"}
+    }
+
+
+    cdl_option CYGPKG_HAL_MIPS_MSBFIRST {
+        display    "CPU Variant big-endian"
+        calculated {   CYGHWR_HAL_MIPS_MIPS32_ENDIAN == "Big"}
     }

     cdl_option CYGPKG_HAL_MIPS_GDB_REPORT_CP0 {
  display "Report contents of CP0 to GDB"
  calculated 1
@@ -130,11 +147,12 @@ cdl_package CYGPKG_HAL_MIPS_MIPS32 {

         cdl_option CYGBLD_GLOBAL_CFLAGS {
             display "Global compiler flags"
             flavor  data
             no_define
-            default_value {
"-mips32 -EL -msoft-float -Wall -Wpointer-arith -Wstrict-prototypes -Winline
 -Wundef -Woverloaded-virtual -g -O2 -ffunction-sections -fdata-sections -fn
o-rtti -fno-exceptions -fvtable-gc -finit-priority -G0" }
+            default_value { CYGPKG_HAL_MIPS_LSBFIRST ?
"-mips32 -EL -msoft-float -Wall -Wpointer-arith -Wstrict-prototypes -Winline
 -Wundef -Woverloaded-virtual -g -O2 -ffunction-sections -fdata-sections -fn
o-rtti -fno-exceptions -fvtable-gc -finit-priority -G0" : \
+









"-mips32 -msoft-float -Wall -Wpointer-arith -Wstrict-prototypes -Winline -Wu
ndef -Woverloaded-virtual -g -O2 -ffunction-sections -fdata-sections -fno-rt
ti -fno-exceptions -fvtable-gc -finit-priority -G0"  }
             description   "
                 This option controls the global compiler flags which
                 are used to compile all packages by
                 default. Individual packages may define
                 options which override these global flags."
@@ -142,11 +160,12 @@ cdl_package CYGPKG_HAL_MIPS_MIPS32 {

         cdl_option CYGBLD_GLOBAL_LDFLAGS {
             display "Global linker flags"
             flavor  data
             no_define
-            default_value {
"-EL -msoft-float -g -nostdlib -Wl,--gc-sections -Wl,-static" }
+            default_value {CYGPKG_HAL_MIPS_LSBFIRST ?
"-EL -msoft-float -g -nostdlib -Wl,--gc-sections -Wl,-static" :\
+       "-msoft-float -g -nostdlib -Wl,--gc-sections -Wl,-static"}
             description   "
                 This option controls the global linker flags. Individual
                 packages may define options which override these global
flags."
         }


----- Original Message -----
From: "Jonathan Larmour" <jifl@eCosCentric.com>
To: "Tim Michals" <t.michals@attbi.com>
Cc: <ecos-patches@sources.redhat.com>
Sent: Friday, January 03, 2003 8:16 AM
Subject: Re: mips32 cld change


> Tim Michals wrote:
> > Added a choice to select little or big endian, this helps building a
variant
> > hal based on mips32 hal.
>
> Before I can check in this patch, there's a few little problems. Firstly
> you didn't update the display or description from what you copied the new
> option from. Secondly, I'd slightly prefer your option values to be just
> "Big" and "Little" to avoid the odd looking (IMHO) hyphenation.
>
> Lastly, you can shorten those lines with the compiler flags on by using
> "CYGPKG_HAL_MIPS_LSBFIRST ? " instead of the longer alternative with the
> new option.
>
> > The default is big-endian, but it might be better to have it default to
> > little for malta board build.
>
> For continuity it's probably best to keep the default as little endian.
>
> Lastly when you generate a patch, can you use "cvs diff -u5 -p" to
> generate it rather than a plain diff? It makes patches much more reliable.
> You can make this the default by adding the line:
>
> diff -u5 -p
>
> to your ~/.cvsrc file.
>
> Also your mailer wrapped the patch at 80 columns anyway, so it was
> definitely corrupted. Try attaching it as an attachment if your mailer
> refuses to co-operate.
>
> Jifl
> --
> eCosCentric       http://www.eCosCentric.com/       <info@eCosCentric.com>
> --[ "You can complain because roses have thorns, or you ]--
> --[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine
>

Attachment: out
Description: Binary data