This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: pxa2x0 platform
On Fri, 2003-01-24 at 01:31, Holger Schurig wrote:
> > This is an impressive port - I've just inspected it and for the first time
> > in a long time I don't have a single comment to make! Unless anyone has
> > any other comments on it (you know who you are :-)) I'd like to check it
> > straight in.
>
> Some...
>
> - some files have CRLF at the end, but the rest of eCos follows Unix
> convention
>
I'm sure that Jonathan will take care of this in the process.
> - in hal/arm/xscale/mpc50/current/include/hal_platform_setup.h I see
> init_mmu_cache_on, init_mmu_off but I have the feeling that this is
> PXA250-specific, not mpc50-specific. The same is true for init_sdram_cnt,
> althought this function needs board-specific values to do it's job.
Fair enough, but it's the standard practice of the ARM ports.
We don't have quite enough flexibility in that particular
portion of the startup code (before much of anything is stable)
to split things that finely.
I think this is fine, really.
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary@mlbassoc.com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------