This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Bash patches

Excellent suggestion!  The diff is now just a single line addition to

--- subst.c.old Thu Oct  5 14:46:28 2000
+++ subst.c     Thu Oct  5 16:35:00 2000
@@ -3307,6 +3307,8 @@ read_comsub (fd, quoted)
   char *istring, buf[128], *bufp;
   int bufn, istring_index, istring_size, c;

+  setmode( fd, O_TEXT );

   istring = (char *)NULL;
   istring_index = istring_size = bufn = 0;

I haven't seen setmode(fd,mode) in any other POSIX environment.  Have I just
missed it or is this a cywin specific thing?

- Erik

----- Original Message -----
From: "Chris Faylor" <>
To: <>
Cc: <>
Sent: October 05, 2000 16:13
Subject: Re: Bash patches

> By the way, I think you should probably just use the same mechanism that
> Cygwin uses to strip CRs.  Setting an input stream to O_TEXT is all that
> is required.  You do that one of three ways:
> open ("foo", O_RDONLY | O_TEXT);
> fopen ("foo", "rt");
> setmode (fd, O_TEXT);
> cgf
> On Thu, Oct 05, 2000 at 04:02:50PM -0600, Erik Nolte wrote:
> >I realize there is currently no bash maintainer, but how do I propose
> >patches and to whom do I send them in the interim?
> >
> >Below are patches to fix:
> >
> >(1) The backtick (command substitution) CR-LF problem I reported on
> >under the title "Has CR/LF and cat problem with textutils-2.0 been
> >read_comsub() was modified in src/bash/subst.c to convert CR-LF into NL
> >immediately after the text is read from the command.
> >
> >(2) The cd/CDPATH erroneous echoing of the path for DOS absolute
> >This was reported on 26Sep00 under the title "Strange cd/CDPATH
> >absolute_pathname() was modified in src/bash/general.c to treat
> >[A-Za-z]:[/\]* as absolute pathnames.
> >
> >I started with the source at
> >
> >ran the diff as "diff -u -p original-file new-file".

Want to unsubscribe from this list?
Send a message to

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]